feat(progress): add pf-progress by brianferry · Pull Request #2511 · patternfly/patternfly-elements

brianferry · 2023-06-06T15:39:27Z

pf-progress

Implemented Patternfly's Progress as web component.

Related issues

(#2508)

Preview

Link(s) to demo page(s) where this element can be viewed:

Link

…l5 element

changeset-bot · 2023-06-06T15:39:31Z

🦋 Changeset detected

Latest commit: d610761

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-06-06T15:41:44Z

✅ Deploy Preview for patternfly-elements ready!

Name	Link
🔨 Latest commit	`a85853e`
😎 Deploy Preview	https://deploy-preview-2511--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

elements/pf-progress/pf-progress.css

elements/pf-progress/docs/pf-progress.md

elements/pf-progress/pf-progress.ts

bennypowers

most pressing change is to put remove the private updateAccessibility method and put that stuff in the template instead

it might we good to set a private property in willUpdate for that purpose

…ssigned elements

bennypowers

LGTM

@brianferry @eyevana please validate the changes to the test files

brianferry · 2023-08-09T13:39:07Z

Tooltip and progress look good to me 👍🏼

elements/pf-popover/pf-popover.ts

elements/pf-popover/test/pf-popover.spec.ts

netlify · 2023-08-17T14:29:39Z

✅ Deploy Preview for patternfly-elements ready!

Name	Link
🔨 Latest commit	`d610761`
🔍 Latest deploy log	https://app.netlify.com/sites/patternfly-elements/deploys/64e353e98f660400084c664c
😎 Deploy Preview	https://deploy-preview-2511--patternfly-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

brianferry added 6 commits May 31, 2023 11:56

feat(progress): adding progress element, adding variants and styles

e3cdfe6

fix(progress): adding accessibility fixes for pf-progress without htm…

58c9cf3

…l5 element

fix: formatting for icons, html

ca5db3b

docs(progress): adding kitchen sink, adding example

87a9670

docs(progress): adding cssprop, summary, kitchen sink demo

4920adc

fix(progress): remove demo css file

1ac5001

github-actions bot added work in progress POC / Not ready for review demo Updating demo pages doc functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing AT passed Automated testing has passed labels Jun 6, 2023

brianferry added 2 commits June 6, 2023 11:41

chore: adding changeset

e800261

Merge branch 'main' into feat/pf-progress

cd07bd9

brianferry marked this pull request as ready for review June 7, 2023 13:20

brianferry added ready: code review Ready for code review! and removed work in progress POC / Not ready for review labels Jun 7, 2023

test: adding test cases for pf-progress

b03d2b7

brianferry linked an issue Jun 8, 2023 that may be closed by this pull request

[1:1]: pf-progress #2508

Closed

Merge branch 'main' into feat/pf-progress

4efcebd

brianferry added this to the PatternFly Elements 2.x milestone Jun 8, 2023

bennypowers reviewed Jun 20, 2023

View reviewed changes

elements/pf-progress/pf-progress.css Show resolved Hide resolved

Merge branch 'main' into feat/pf-progress

a257e91

bennypowers reviewed Jun 20, 2023

View reviewed changes

elements/pf-progress/docs/pf-progress.md Show resolved Hide resolved

bennypowers reviewed Jun 20, 2023

View reviewed changes

elements/pf-progress/pf-progress.ts Outdated Show resolved Hide resolved

bennypowers reviewed Jun 20, 2023

View reviewed changes

elements/pf-progress/pf-progress.ts Outdated Show resolved Hide resolved

bennypowers requested changes Jun 20, 2023

View reviewed changes

bennypowers and others added 13 commits August 8, 2023 15:58

style(switch): whitespace

f990a79

feat(tooltip): trigger, flip

9387379

docs(popover): added flip demo

8155ba3

feat(progress): truncated title

23e666b

docs(progress): typos

dbf36c6

fix(progress): truncated

30871a4

fix(tooltip): detect when invoker slot should be block level

a6886f6

test(popover): clarify tests

f49edc1

fix(tooltip): tooltip invoker is called depending on whether it has a…

372f2ed

…ssigned elements

perf(popover): reassign trigger less often

ad77a77

feat(tools): click element center test util

75af29b

test(popover): rationalize tests

e08600a

perf(tooltip): calculate internal state less often

8a02902

github-actions bot added the tools Development and build tools label Aug 9, 2023

bennypowers approved these changes Aug 9, 2023

View reviewed changes

eyevana reviewed Aug 9, 2023

View reviewed changes

elements/pf-popover/pf-popover.ts Show resolved Hide resolved

elements/pf-popover/pf-popover.ts Outdated Show resolved Hide resolved

fix: trigger attached by reference should toggle popover

8787851

eyevana reviewed Aug 10, 2023

View reviewed changes

elements/pf-popover/test/pf-popover.spec.ts Outdated Show resolved Hide resolved

eyevana and others added 2 commits August 11, 2023 15:06

fix: test nesting

ff49508

Merge branch 'main' into feat/pf-progress

d478bc5

bennypowers added 4 commits August 20, 2023 12:13

test(popover): refactor tests

d730655

test: refactor

69619e3

chore: fix netlify deploy command

4e4e325

refactor(progress): remove unused variable

f49d0cf

bennypowers enabled auto-merge (squash) August 21, 2023 12:09

Merge branch 'main' into feat/pf-progress

d610761

bennypowers merged commit dcdbce6 into main Aug 21, 2023

bennypowers deleted the feat/pf-progress branch August 21, 2023 12:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(progress): add pf-progress#2511

feat(progress): add pf-progress#2511
bennypowers merged 60 commits intomainfrom
feat/pf-progress

brianferry commented Jun 6, 2023 •

edited

Loading

Uh oh!

changeset-bot bot commented Jun 6, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jun 6, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bennypowers left a comment

Uh oh!

bennypowers left a comment

Uh oh!

brianferry commented Aug 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Aug 17, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

brianferry commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

pf-progress

Related issues

Preview

Uh oh!

changeset-bot bot commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for patternfly-elements ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bennypowers left a comment

Choose a reason for hiding this comment

Uh oh!

bennypowers left a comment

Choose a reason for hiding this comment

Uh oh!

brianferry commented Aug 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for patternfly-elements ready!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

brianferry commented Jun 6, 2023 •

edited

Loading

changeset-bot bot commented Jun 6, 2023 •

edited

Loading

github-actions bot commented Jun 6, 2023 •

edited

Loading

netlify bot commented Aug 17, 2023 •

edited

Loading